Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with mutating account after saving #3612

Merged
merged 1 commit into from Nov 15, 2019

Conversation

@chimp1984
Copy link
Contributor

chimp1984 commented Nov 15, 2019

Fixes #3572

We saved the account and afterwards called setSelectedTradeCurrency.
That caused a bug with remove as the hash at insert was different as at
remove.

Fixes #3572
We saved the account and afterwards called setSelectedTradeCurrency.
That caused a bug with remove as the hash at insert was different as at
remove.
@chimp1984 chimp1984 requested review from ripcurlx and sqrrm as code owners Nov 15, 2019
@chimp1984 chimp1984 changed the title Fixes https://github.com/bisq-network/bisq/pull/3572 Fix bug with mutating account after saving Nov 15, 2019
@freimair

This comment has been minimized.

Copy link
Member

freimair commented Nov 15, 2019

I recon that this also fixes #3461?

Copy link
Member

ripcurlx left a comment

utACK

@ripcurlx ripcurlx merged commit fb96ad3 into bisq-network:master Nov 15, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@chimp1984

This comment has been minimized.

Copy link
Contributor Author

chimp1984 commented Nov 15, 2019

I recon that this also fixes #3461?

Yes. I have not tested it but I am pretty sure.

@chimp1984 chimp1984 deleted the chimp1984:fix-bug-with-account-delete branch Nov 16, 2019
@chimp1984 chimp1984 mentioned this pull request Nov 26, 2019
@ripcurlx ripcurlx mentioned this pull request Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.