Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with mutating account after saving #3612

Merged
merged 1 commit into from Nov 15, 2019
Merged

Fix bug with mutating account after saving #3612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...main/java/bisq/desktop/main/account/content/altcoinaccounts/AltCoinAccountsDataModel.java
View file
Open in desktop
Expand Up @@ -103,7 +103,6 @@ protected void deactivate() {
///////////////////////////////////////////////////////////////////////////////////////////

public void onSaveNewAccount(PaymentAccount paymentAccount) {
user.addPaymentAccount(paymentAccount);
TradeCurrency singleTradeCurrency = paymentAccount.getSingleTradeCurrency();
List<TradeCurrency> tradeCurrencies = paymentAccount.getTradeCurrencies();
if (singleTradeCurrency != null) {
Expand All @@ -120,6 +119,8 @@ public void onSaveNewAccount(PaymentAccount paymentAccount) {
});
}

user.addPaymentAccount(paymentAccount);

if (!(paymentAccount instanceof AssetAccount))
accountAgeWitnessService.publishMyAccountAgeWitness(paymentAccount.getPaymentAccountPayload());
}
Expand Down
3 changes: 2 additions & 1 deletion ...p/src/main/java/bisq/desktop/main/account/content/fiataccounts/FiatAccountsDataModel.java
View file
Open in desktop
Expand Up @@ -106,7 +106,6 @@ protected void deactivate() {
///////////////////////////////////////////////////////////////////////////////////////////

public void onSaveNewAccount(PaymentAccount paymentAccount) {
user.addPaymentAccount(paymentAccount);
TradeCurrency singleTradeCurrency = paymentAccount.getSingleTradeCurrency();
List<TradeCurrency> tradeCurrencies = paymentAccount.getTradeCurrencies();
if (singleTradeCurrency != null) {
Expand All @@ -128,6 +127,8 @@ public void onSaveNewAccount(PaymentAccount paymentAccount) {
});
}

user.addPaymentAccount(paymentAccount);

accountAgeWitnessService.publishMyAccountAgeWitness(paymentAccount.getPaymentAccountPayload());
}

Expand Down