Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package.bat version parsing #3631

Merged
merged 1 commit into from Nov 19, 2019
Merged

Conversation

@devinbileck
Copy link
Member

devinbileck commented Nov 19, 2019

The package.bat script parses the first 3 tokens of the version string
to determine the file version. This is done to strip "-SNAPSHOT" from
the version string since the file version can only contain a numeric
version number.

The package.bat script parses the first 3 tokens of the version string
to determine the file version. This is done to strip "-SNAPSHOT" from
the version string since the file version can only contain a numeric
version number.
@devinbileck devinbileck requested review from ripcurlx and sqrrm as code owners Nov 19, 2019
Copy link
Member

ripcurlx left a comment

utACK

@ripcurlx ripcurlx merged commit ad0cfd2 into bisq-network:master Nov 19, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@devinbileck devinbileck deleted the devinbileck:fix-package.bat branch Nov 19, 2019
@devinbileck devinbileck mentioned this pull request Dec 13, 2019
@ripcurlx ripcurlx mentioned this pull request Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.