Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement installation path check on Windows #3642

Merged
merged 4 commits into from Nov 20, 2019

Conversation

@devinbileck
Copy link
Member

devinbileck commented Nov 20, 2019

Prior to starting the installation, check if the install location
contains special characters and if so use a different default install
location as well as display a prompt to the user providing additional
details.

This is in response to #3605, for which a proper solution has yet to be
found.

devinbileck added 4 commits Nov 19, 2019
Prior to starting the installation, check if the install location
contains special characters and if so use a different default install
location as well as display a prompt to the user providing additional
details.

This is in response to #3605, for which a proper solution has yet to be
found.
This resolves #552
Rather then potentially being greeted with the newly implemented
prompt on the destination location dialog if they have special
characters in their install path, greet the user with the Welcome
dialog when they initially launch the installer.
Copy link
Member

ripcurlx left a comment

utACK - Thanks for fixing this! 👍

@ripcurlx ripcurlx merged commit 778e9b2 into bisq-network:master Nov 20, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@devinbileck devinbileck deleted the devinbileck:installer-check-app-path branch Nov 20, 2019
@devinbileck devinbileck mentioned this pull request Dec 13, 2019
@ripcurlx ripcurlx mentioned this pull request Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.