Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and cleanup #3643

Merged
merged 1 commit into from Nov 21, 2019
Merged

Fix typos and cleanup #3643

merged 1 commit into from Nov 21, 2019

Conversation

@rex4539
Copy link
Contributor

rex4539 commented Nov 20, 2019

No description provided.

@rex4539 rex4539 requested a review from ripcurlx as a code owner Nov 20, 2019
Copy link
Member

ripcurlx left a comment

utACK - I guess now you have found all of them 😉

@ripcurlx ripcurlx merged commit 871051f into bisq-network:master Nov 21, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rex4539

This comment has been minimized.

Copy link
Contributor Author

rex4539 commented Nov 21, 2019

I actually found some more later and filed #3647 :)

@rex4539 rex4539 deleted the rex4539:fix-typos branch Nov 21, 2019
@rex4539 rex4539 mentioned this pull request Nov 23, 2019
@julianknutsen

This comment has been minimized.

Copy link
Contributor

julianknutsen commented Nov 23, 2019

@ripcurlx I didn't have any pain rebasing these fixes this time, but this is the type of change that can cause massive headaches for other developers with outstanding PRs and in-process development work. In the future, it might be nice to either have a pseudo code-freeze for style patches that touch so many files. That way it is a known rebase point for master to limit merge pain. I appreciate the intention of the patch, but future ones in a similar style could be a lot more painful.

@ripcurlx ripcurlx mentioned this pull request Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.