Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve account signing security #3682

Merged
merged 2 commits into from Nov 26, 2019

Conversation

@ripcurlx
Copy link
Member

ripcurlx commented Nov 25, 2019

No description provided.

ripcurlx added 2 commits Nov 22, 2019
… signing

Should make it easier to detect by a stolen bank account owner as buyer that an outgoing transactions is taking place.
This prevents a scammer to use publicly known account details
(without being in control of the account) as a seller to get
signed by a buyer. The money received in the seller account might
not be detected by the legitimate owner and/or the money not sent back.
30 days later the scammer could use this signed account as seed to peer sign other stolen accounts.
@ripcurlx ripcurlx requested a review from sqrrm as a code owner Nov 25, 2019
Copy link
Member

freimair left a comment

utAck. Did a small smoke test though.

@freimair freimair mentioned this pull request Nov 26, 2019
@freimair freimair merged commit d12843a into bisq-network:master Nov 26, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ripcurlx ripcurlx mentioned this pull request Dec 13, 2019
@ripcurlx ripcurlx deleted the ripcurlx:improve-account-signing branch Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.