Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zh_hant translations (Chinese Traditional) #3714

Merged
merged 2 commits into from Dec 3, 2019

Conversation

@wiz
Copy link
Member

wiz commented Nov 28, 2019

Screen Shot 2019-11-29 at 14 54 13

Screen Shot 2019-11-29 at 14 54 46

Screen Shot 2019-11-29 at 14 54 35

Screen Shot 2019-11-29 at 14 55 36

Screen Shot 2019-11-29 at 14 56 11

Screen Shot 2019-11-29 at 14 56 34

Screen Shot 2019-11-29 at 14 57 03

Screen Shot 2019-11-29 at 14 57 25

Screen Shot 2019-11-29 at 15 08 12

Screen Shot 2019-11-29 at 15 08 46

Screen Shot 2019-11-29 at 15 09 11

Screen Shot 2019-11-29 at 15 09 59

Screen Shot 2019-11-29 at 15 11 22

@wiz wiz requested a review from ripcurlx as a code owner Nov 28, 2019
@wiz wiz force-pushed the wiz:add-chinese-traditional branch 2 times, most recently from a7d51c2 to 306b7ae Nov 29, 2019
@wiz wiz changed the title Add zh_TW translations (Chinese Traditional) Add zh_hant translations (Chinese Traditional) Nov 29, 2019
Copy link
Member

ripcurlx left a comment

NACK - @wiz Thanks for the changes. I don't remember anymore if there was a reason not to support country specific language files, but I don't see a reason why not to do it. Please see my comment regarding one missing change.

core/update_translations.sh Show resolved Hide resolved
@ripcurlx

This comment has been minimized.

Copy link
Member

ripcurlx commented Dec 2, 2019

@arunasurya @wiz We do have Chinese simplified already as a supported core language, but not traditional Chinese. How do we want to handle the adding of country variants of an existing language? I think it would be good to have something official (proposal or similar) to state the reasoning for adding this new language variant (as it also immediately makes it eligible for compensation)

@arunasurya

This comment has been minimized.

Copy link
Contributor

arunasurya commented Dec 2, 2019

@ripcurlx , I agree with you that it is good to have clear reasoning for adding a new language. Right now, we don't have a clear policy but rather rough guidelines. Perhaps it is a good idea to have a more explicit policy. Meanwhile, I am communicating with the two translators who have done (ff98sha and wdljt) to figure out how important traditional Chinese is for Bisq, etc.

@cryptosnip

This comment has been minimized.

Copy link

cryptosnip commented Dec 3, 2019

@ripcurlx

This comment has been minimized.

Copy link
Member

ripcurlx commented Dec 3, 2019

1.4 Billion people speak & write Mandarin - 1/3 the worlds population. So what is the the problem??

There is no problem with it, we just should have a transparent workflow when a new language or language variant is added as we only support a couple of core languages right now which are also up for compensation. Just to change it within a PR might go through unnoticed and might cause irritation by others who want to get their language added to Bisq as well.

@ripcurlx

This comment has been minimized.

Copy link
Member

ripcurlx commented Dec 3, 2019

@ripcurlx , I agree with you that it is good to have clear reasoning for adding a new language. Right now, we don't have a clear policy but rather rough guidelines. Perhaps it is a good idea to have a more explicit policy. Meanwhile, I am communicating with the two translators who have done (ff98sha and wdljt) to figure out how important traditional Chinese is for Bisq, etc.

I think it is important, but it was only communicated through personal chat with me from @wiz. So I'm up for adding it in this case as it is just a language variant and it would add native language support for people based in Hongkong.

@wiz wiz force-pushed the wiz:add-chinese-traditional branch from 306b7ae to 07ff156 Dec 3, 2019
wiz added 2 commits Nov 29, 2019
@wiz wiz force-pushed the wiz:add-chinese-traditional branch from 07ff156 to 4dab4fc Dec 3, 2019
Copy link
Member

ripcurlx left a comment

ACK

Tested it locally on Regtest and also tried to update translations from Transifex. Everything works as expected.

@ripcurlx ripcurlx merged commit 037f167 into bisq-network:master Dec 3, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@wiz wiz deleted the wiz:add-chinese-traditional branch Dec 4, 2019
@arunasurya

This comment has been minimized.

Copy link
Contributor

arunasurya commented Dec 5, 2019

I think that the translators should have made a proposal to add a new language before it was merged. I was looking into it and tried to evaluate if it should be a core language. I don't think there was a consensus on adding traditional Chinese from all sides...Is it now officially a core language?

P.S. I think we need to have a clearer process of adding a new language. I have stared writing it up in the Bisq translator documentation (on my github site) but it is not official since the documentation is not on Bisq. I guess there was a lack of clear communication on my part. I would be happy to talk to the translators and come up with a more concrete process.

@ripcurlx ripcurlx mentioned this pull request Dec 13, 2019
@wiz wiz mentioned this pull request Dec 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.