Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use 0 btc outputs #3725

Merged
merged 3 commits into from Dec 2, 2019
Merged

Conversation

@chimp1984
Copy link
Contributor

chimp1984 commented Dec 1, 2019

@ripcurlx Please cherry pick that to the release branch.

Fixes #3721 and #3722 but there are more issues open as a payout with only 1 receiver still cause a trade to end up in failed trades.

chimp1984 added 2 commits Dec 1, 2019
Fixes #3721 and
#3722

There are still more issues as such a payout tx will cause that the
trade ends up in failed trades. This commit only fixes the invalid
tx issue.
@chimp1984 chimp1984 requested a review from ripcurlx as a code owner Dec 1, 2019
If we do not get any BTC from a mediated payout tx we do not know about
the confirmation state so it would stay always in the unconfirmed state.
To avoid that confusion we prefer to hide the icon. This is a known
issue from BitcoinJ but we have not found a solution for that yet.
@chimp1984 chimp1984 requested a review from sqrrm as a code owner Dec 2, 2019
Copy link
Member

ripcurlx left a comment

utACK

@ripcurlx ripcurlx merged commit 77b2360 into bisq-network:master Dec 2, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@chimp1984 chimp1984 deleted the chimp1984:do-not-use-0BTC-outputs branch Dec 3, 2019
@chimp1984 chimp1984 mentioned this pull request Dec 7, 2019
@ripcurlx ripcurlx mentioned this pull request Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.