Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling of mediationResultState to isFundsLockedIn #3726

Conversation

@chimp1984
Copy link
Contributor

chimp1984 commented Dec 2, 2019

Fixes #3727
(part of the problem was that the trade ended up in failed trade)

Refactor method and add comments.
We did not handle the case of a mediated payout. isPayoutPublished() is
only reflecting non-disputed trade payouts.

@ripcurlx Please cherry pick to release branch.

Fixes #3721
(part of the problem was that the trade ended up in failed trade)

Refactor method and add comments.
We did not handle the case of a mediated payout. isPayoutPublished() is
only reflecting non-disputed trade payouts.
Copy link
Member

ripcurlx left a comment

utACK

@ripcurlx ripcurlx merged commit 51982fd into bisq-network:master Dec 2, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@chimp1984 chimp1984 deleted the chimp1984:do-not-move-mediated-trades-to-failed-trades branch Dec 3, 2019
@chimp1984 chimp1984 mentioned this pull request Dec 7, 2019
@ripcurlx ripcurlx mentioned this pull request Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.