Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Rename "Spread" tab to a more general "Details" #3745
Because spread is one of many columns in the table in the "Spread" tab, calling the whole tab "Spread" is not general enough. Calling the table "Details" is more general and is meant to signify that it offers more information than the "offer book" view.
A counter-argument would be that 1) the table does not actually offer new information, just new aggregates on the same information displayed under "Offer book"; and 2), "Details" is somewhat vague.
Currently, it is unclear what a more accurate title could be, and in the meantime "Details" is an improvement on "Spread".
julianknutsen left a comment
The Spanish version still has the old text which I think is to be expected. I have no experience with how the translations are done, so someone with a better understanding of the workflow can weigh in here.
As far as your analysis on whether or not this is the "best" text. I think that this issue has been up for review for almost two months now so any sort of bikeshedding on it should have happened. The new text is definitely moving it in the right direction imo.
@dmos62 @ julianknutsen Only the English translation is to be changed on master. If the value for one key is changing it is marked untranslated on Transifex and translators can pick it up for translation. Before each release I'm pulling the translations from Transifex and update it in the repository.