Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate wallet date when restoring from seed #3749

Merged
merged 1 commit into from Dec 6, 2019

Conversation

@devinbileck
Copy link
Member

devinbileck commented Dec 5, 2019

Prevent a date that is older than the oldest wallet date, or a date that
is newer than the current date.

Prevent a date that is older than the oldest wallet date, or a date that
is newer than the current date.
@sqrrm
sqrrm approved these changes Dec 6, 2019
Copy link
Member

sqrrm left a comment

utACK

@sqrrm sqrrm merged commit 87fb9c0 into bisq-network:master Dec 6, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@devinbileck devinbileck deleted the devinbileck:restore-from-seed branch Dec 6, 2019
Copy link
Contributor

chimp1984 left a comment

For the oldest date I think we should use the latest v0.5 release date as that is when we changed wallet format.

@devinbileck

This comment has been minimized.

Copy link
Member Author

devinbileck commented Dec 9, 2019

Though it may not be desired, I believe it is technically possible to restore prior to that. I figured it would be best to give the user the possibility to do that.
Perhaps it makes sense to implement feedback within the UI to inform/ask the user when they attempt to restore without specifying a date. At a minimum, inform them what happens when they dont specify a date, and inform them that any current Bisq wallet does not date older than the v0.5 release date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.