Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes dark mode switch after restart #3771

Merged

Conversation

@ripcurlx
Copy link
Member

ripcurlx commented Dec 9, 2019

Also includes a minor cleanup of an unnecessary indirection.
Fixes #3447.0
Superseds #3754.

Test cases

Tested on Regtest.

Set custom withdrawal fee

  • Withdraw BTC from Funds > Send Funds
  • Check withdrawal fee in popup
  • Set in settings a custom withdrawal fee of double value (e.g. 20)
  • Withdraw BTC from Funds > Send Funds
  • Check if withdrawal fee in popup was doubled as well

Toggle dark mode

  • Activate dark mode
  • Check if dark mode was enabled
  • Restart app
  • Deactivate dark mode
  • Check if light mode is enabled
ripcurlx added 2 commits Dec 9, 2019
@ripcurlx ripcurlx changed the title Fixes dark monde switch after restart Fixes dark mode switch after restart Dec 9, 2019
Copy link
Member

freimair left a comment

Ack

@freimair freimair merged commit 30f9664 into bisq-network:master Dec 9, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@freimair freimair mentioned this pull request Dec 9, 2019
@ripcurlx ripcurlx added this to the v1.2.5 milestone Dec 10, 2019
@ripcurlx ripcurlx mentioned this pull request Dec 13, 2019
@ripcurlx ripcurlx deleted the ripcurlx:fix-dark-mode-switch-plus-cleanup branch Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.