Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revolut account should accept only phone number #3777

Merged

Conversation

@beingindot
Copy link
Contributor

beingindot commented Dec 12, 2019

Fixes #3728
Till now we used to accept email or phone number
Now we are accepting only phone number in input though
for display we will provide backward compatibility.

Based on the country selected, we will validate the given phone number input.

Added list of countries accepted from official revolut website
https://www.revolut.com/en-US/help/getting-started/verifying-identity/what-countries-are-supported

@beingindot beingindot requested review from ripcurlx and sqrrm as code owners Dec 12, 2019
@beingindot beingindot force-pushed the beingindot:revolut-phonenumber-validation branch from 6a888a5 to 0ee88af Dec 12, 2019
@ripcurlx ripcurlx added this to the v1.2.5 milestone Dec 12, 2019
Copy link
Member

ripcurlx left a comment

NACK

I tested it on Regtest and when switching the country in the combobox the validation is not updated. See screenshots below.

Bildschirmfoto 2019-12-12 um 15 42 54
When I switch the country to German the validation condition should be fulfilled, but is still showing the Austrian country code error message
Bildschirmfoto 2019-12-12 um 15 43 05

@beingindot beingindot force-pushed the beingindot:revolut-phonenumber-validation branch from 0ee88af to e9e1620 Dec 13, 2019
@beingindot

This comment has been minimized.

Copy link
Contributor Author

beingindot commented Dec 13, 2019

Now I have added updateAllInputsValid() from combobox action event. that triggers validation and it enables save new account.

but the error message around text field is not clearing on its own. only after we press tab it clears. I tried to use accountIdInputTextField.resetValidation() but not working so far. may be that's an existing bug? pls provide suggestions.

@ripcurlx ripcurlx mentioned this pull request Dec 13, 2019
@ripcurlx

This comment has been minimized.

Copy link
Member

ripcurlx commented Dec 17, 2019

resetValidation

It has to be used similar as in the Bankform

holderNameInputTextField.resetValidation();
holderNameInputTextField.validate();
For issue #3728
	Till now we used to accept email or phone number
	Now we are accepting only phone number in input though
	for display we will provide backward compatibility.

	Added list of countries accepted from official revolut website
	https://www.revolut.com/en-US/help/getting-started/verifying-identity/what-countries-are-supported

	Based on the country selected, we will validate the given
	phone number input.
@beingindot beingindot force-pushed the beingindot:revolut-phonenumber-validation branch from e9e1620 to da683e8 Dec 17, 2019
Copy link
Member

ripcurlx left a comment

ACK

Tested it on Regtest and it is working now as expected.

@ripcurlx ripcurlx merged commit 543a11e into bisq-network:master Dec 18, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@beingindot beingindot mentioned this pull request Jan 13, 2020
@ripcurlx ripcurlx mentioned this pull request Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.