Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user preference combobox for BSQ block explorer with random default #3792

Merged
merged 3 commits into from Dec 18, 2019

Conversation

@wiz
Copy link
Member

wiz commented Dec 15, 2019

Screen Shot 2019-12-16 at 0 21 25

Implements bisq-network/proposals#143

Needs review and testing

Copy link
Contributor

chimp1984 left a comment

utACK

IMO betanet and testnet can be removed...

core/src/main/java/bisq/core/user/Preferences.java Outdated Show resolved Hide resolved
core/src/main/java/bisq/core/user/Preferences.java Outdated Show resolved Hide resolved
Copy link
Member

ripcurlx left a comment

NACK - please see the comments from @chimp1984 and myself.

core/src/main/java/bisq/core/user/Preferences.java Outdated Show resolved Hide resolved
@wiz wiz requested a review from ripcurlx Dec 17, 2019
Copy link
Member

sqrrm left a comment

utACK

@ripcurlx ripcurlx added this to the v1.2.5 milestone Dec 18, 2019
Copy link
Member

ripcurlx left a comment

ACK

Tested it on Mainnet and everything works as expected for @wiz explorer. @sqrrm explorer should be available for our v1.2.5 release

@ripcurlx ripcurlx merged commit 2782e58 into bisq-network:master Dec 18, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@wiz wiz deleted the wiz:add-bsq-explorer-combobox branch Dec 18, 2019
@ripcurlx ripcurlx mentioned this pull request Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.