Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove listener before setting a new one #3796

Merged
merged 1 commit into from Dec 16, 2019

Conversation

@ripcurlx
Copy link
Member

ripcurlx commented Dec 16, 2019

Fixes #3731.

Experienced it nearly every time when testing #3790. After this fix I didn't saw this issue again.

Testing

Using master:

  • Create 3+ mediation cases
  • Close a single mediation entry
  • You will see another mediation entry to be deactivated as well (opacity: 0.4)

Using this PR:

  • Create 3+ mediation cases
  • Close a single mediation entry
  • Only this one entry should be deactivated
This fixes update issues reported in #3731.
@ripcurlx ripcurlx requested a review from sqrrm as a code owner Dec 16, 2019
@sqrrm
sqrrm approved these changes Dec 16, 2019
Copy link
Member

sqrrm left a comment

utACK

I haven't tested the case it's supposed to fix, but in isolation this PR looks correct on its own.

@sqrrm sqrrm merged commit 737a419 into bisq-network:master Dec 16, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ripcurlx ripcurlx added this to the v1.2.5 milestone Dec 17, 2019
@ripcurlx ripcurlx deleted the ripcurlx:fix-rendering-issue-of-disputes branch Dec 18, 2019
@sqrrm sqrrm mentioned this pull request Jan 13, 2020
@ripcurlx ripcurlx mentioned this pull request Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.