Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix random BSQ block explorer selection by setting Nullable #3802

Merged

Conversation

@wiz
Copy link
Member

wiz commented Dec 18, 2019

After more testing I found a bug in #3792 that would not always use the random selector, should be fixed now. Testcase:

  1. Erase data dir
  2. Start Bisq
  3. Check value of settings -> BSQ block explorer
  4. Repeat a bunch of times
    [Expected Result]
    BSQ block explorer should be randomly selected (i.e. different sometimes)
@wiz wiz requested a review from ripcurlx as a code owner Dec 18, 2019
Copy link
Member

ripcurlx left a comment

ACK

Missed this in my last review as well

@ripcurlx ripcurlx merged commit 8a279c7 into bisq-network:master Dec 18, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@wiz wiz deleted the wiz:fix-bsq-explorer-always-picking-wiz branch Dec 18, 2019
@ripcurlx ripcurlx added this to the v1.2.5 milestone Jan 2, 2020
@ripcurlx ripcurlx mentioned this pull request Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.