Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dark mode styles #3803

merged 2 commits into from Dec 19, 2019


Copy link

ripcurlx commented Dec 18, 2019

Fixes progress bar track issue and popover text readability issue in #3185.
Bildschirmfoto 2019-12-18 um 13 03 27

ripcurlx added 2 commits Dec 18, 2019
@ripcurlx ripcurlx requested a review from sqrrm as a code owner Dec 18, 2019
@ripcurlx ripcurlx requested a review from wiz Dec 18, 2019
wiz approved these changes Dec 18, 2019
Copy link

wiz left a comment

My hero! Your .popover class styling with !important hack fixes the 2 bugs

sqrrm approved these changes Dec 19, 2019
Copy link

sqrrm left a comment


@sqrrm sqrrm merged commit 0efbe06 into bisq-network:master Dec 19, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed

This comment has been minimized.

Copy link

wiz commented Dec 20, 2019

Unfortunately after more testing I noticed that other progress bars were affected, that shouldn't have been - I will make a new PR
Screen Shot 2019-12-21 at 3 03 33
Screen Shot 2019-12-20 at 2 31 26
Screen Shot 2019-12-21 at 3 04 51
Screen Shot 2019-12-21 at 3 05 04

@ripcurlx ripcurlx added this to the v1.2.5 milestone Jan 2, 2020
@sqrrm sqrrm mentioned this pull request Jan 13, 2020
@ripcurlx ripcurlx mentioned this pull request Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.