Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes remaining dark mode bugs (except chat bubbles) #3808

Merged
merged 2 commits into from Dec 19, 2019

Conversation

@ripcurlx
Copy link
Member

ripcurlx commented Dec 19, 2019

I think with this PR all bugs mentioned in #3185 except for the chat bubbles color tuning
and adding of the dark mode image for the tip of the bubble afterwards should be fixed.

Bildschirmfoto 2019-12-19 um 11 34 27

Bildschirmfoto 2019-12-19 um 11 42 42

ripcurlx added 2 commits Dec 19, 2019
After some testing on Regtest it seems that this workaround is no longer needed.
This fixes the issue for the remove button mentioned in #3185.
It also removes a style workaround that is not needed anymore.
Side note: the style that was set never existed anyways.
@ripcurlx ripcurlx requested a review from sqrrm as a code owner Dec 19, 2019
@ripcurlx ripcurlx requested a review from wiz Dec 19, 2019
@sqrrm
sqrrm approved these changes Dec 19, 2019
Copy link
Member

sqrrm left a comment

utACK

@sqrrm sqrrm merged commit ab35dbc into bisq-network:master Dec 19, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ripcurlx ripcurlx added this to the v1.2.5 milestone Jan 2, 2020
@ripcurlx ripcurlx mentioned this pull request Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.