Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase security deposits #3826

Merged
merged 2 commits into from Jan 2, 2020

Conversation

@chimp1984
Copy link
Contributor

chimp1984 commented Dec 23, 2019

Implement adjustment according to: bisq-network/proposals#155

For buyer:
Default: 15%
Min. 15% for Altcoin, 15% for Fiat
Max. 50% for Altcoin, 50% for Fiat
Absolute min. deposit in BTC: 0.006 BTC (currently 40 USD)

For Seller:
Fixed: 15%
Absolute min. deposit in BTC: 0.006 BTC (currently 40 USD)

Testing:
Create all offer types with min. sec. deposit, max. sec. deposit, min. trade amount, max. trade amount for both buy and sell side and fiat and altcoins. Take all offers and exectute trade if all works.
Also test backward compatibility with one node on PR version and one on master with all above combinations.

chimp1984 added 2 commits Dec 23, 2019
According to bisq-network/proposals#155

For buyer:
Default: 15%
Min. 15% for Altcoin, 15% for Fiat
Max. 50% for Altcoin, 50% for Fiat
Absolute min. deposit in BTC: 0.006 BTC (currently 40 USD)

For Seller:
Fixed: 15%
Absolute min. deposit in BTC: 0.006 BTC (currently 40 USD)
@chimp1984 chimp1984 requested review from ripcurlx and sqrrm as code owners Dec 23, 2019
@chimp1984 chimp1984 mentioned this pull request Dec 23, 2019
@ripcurlx

This comment has been minimized.

Copy link
Member

ripcurlx commented Dec 27, 2019

Just a heads up that I haven't planed to be available until 2nd of Jan, but I'll still try to do some reviews tomorrow.

@sqrrm
sqrrm approved these changes Jan 2, 2020
Copy link
Member

sqrrm left a comment

utACK

I notice that the min security deposit is now 0.006 for both buyers and sellers. This wasn't discussed much in the proposal but it's along the lines of aligning buyers and sellers security deposits.

@sqrrm sqrrm merged commit eeea465 into bisq-network:master Jan 2, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sqrrm

This comment has been minimized.

Copy link
Member

sqrrm commented Jan 2, 2020

During testing it might be worth taking care to test that the different verifiers don't work against each other to cause impossible conditions.

@ripcurlx ripcurlx added this to the v1.2.5 milestone Jan 2, 2020
@sqrrm sqrrm mentioned this pull request Jan 13, 2020
@chimp1984 chimp1984 deleted the chimp1984:increase-security-deposits branch Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.