Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only move to failed trades if the reject msg is critical #3830

Conversation

@chimp1984
Copy link
Contributor

chimp1984 commented Dec 25, 2019

We got a report where a "tx already known" message caused a failed
trade but the deposit tx was valid.
To avoid such false positives we only handle reject messages which
we consider clearly critical.

Testing:
It is hard to test as more exotic reject messages are hard to generate. When the feature was implemented I tested by setting the miner fee to 0.

We got a report where a "tx already known" message caused a failed
trade but the deposit tx was valid.
To avoid such false positives we only handle reject messages which
we consider clearly critical.
@chimp1984 chimp1984 requested a review from ripcurlx as a code owner Dec 25, 2019
@chimp1984 chimp1984 mentioned this pull request Dec 25, 2019
@ripcurlx

This comment has been minimized.

Copy link
Member

ripcurlx commented Dec 27, 2019

Just a heads up that I haven't planed to be available until 2nd of Jan, but I'll still try to do some reviews tomorrow.

Copy link
Member

ripcurlx left a comment

utACK

@ripcurlx ripcurlx merged commit 9a55847 into bisq-network:master Jan 2, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ripcurlx ripcurlx added this to the v1.2.5 milestone Jan 2, 2020
@ripcurlx ripcurlx mentioned this pull request Jan 13, 2020
@chimp1984 chimp1984 deleted the chimp1984:only-move-to-failed-trades-for-critical-reject-msg branch Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.