Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trade limit error message is not clear #3834

Merged
merged 1 commit into from Jan 2, 2020

Conversation

@beingindot
Copy link
Contributor

beingindot commented Dec 26, 2019

Fixes #3712

This will resolve the trade limit error message confusion.

While debugging i have noticed that and function is not propagating properly i.e (not terminating when invalid condition met) to resolve that issue working on a seperate PR and will submit that seperately.

	Fixes #3712
@beingindot beingindot requested review from ripcurlx and sqrrm as code owners Dec 26, 2019
@ripcurlx

This comment has been minimized.

Copy link
Member

ripcurlx commented Dec 27, 2019

Just a heads up that I haven't planed to be available until 2nd of Jan, but I'll still try to do some reviews tomorrow.

Copy link
Member

ripcurlx left a comment

utACK

@ripcurlx ripcurlx added this to the v1.2.5 milestone Jan 2, 2020
@ripcurlx ripcurlx merged commit bd81843 into bisq-network:master Jan 2, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@beingindot beingindot mentioned this pull request Jan 13, 2020
@ripcurlx ripcurlx mentioned this pull request Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.