Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify seednode install script to use GitHub API for latest release tag #3853

Merged
merged 1 commit into from Jan 5, 2020

Conversation

@wiz
Copy link
Member

wiz commented Jan 3, 2020

Replace hard-coded tag in seednode installer script with a GitHub API call to get latest release tag

@wiz wiz requested a review from ripcurlx as a code owner Jan 3, 2020
@wiz wiz force-pushed the wiz:seednode-installer-github-api branch from 03bb367 to 018a9fe Jan 4, 2020
Copy link
Member

devinbileck left a comment

utACK

@sqrrm
sqrrm approved these changes Jan 5, 2020
Copy link
Member

sqrrm left a comment

utACK

We have to be aware that we might not always want to upgrade to the latest bitcoind if there are features removed that we need.

@sqrrm sqrrm merged commit 6a9c0c8 into bisq-network:master Jan 5, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@wiz wiz deleted the wiz:seednode-installer-github-api branch Jan 5, 2020
@ripcurlx ripcurlx added this to the v1.2.5 milestone Jan 7, 2020
@sqrrm sqrrm mentioned this pull request Jan 13, 2020
@wiz wiz mentioned this pull request Jan 14, 2020
@devinbileck devinbileck mentioned this pull request Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.