Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix account age format when ended in 1 #3857

Merged
merged 1 commit into from Jan 5, 2020
Merged

Conversation

@rafaelpac
Copy link
Contributor

rafaelpac commented Jan 5, 2020

The method formatAccountAge is replacing the string "1 days" for "1 day".
This is done to fix the plural for that case.
But it is also changing strings like "21 days" into "21 day".

image

image

The method formatAccountAge is replacing the string "1 days" for "1 day".
This is done to fix the plural for that case.
But it is also changing strings like "21 days" into "21 day".
@rafaelpac rafaelpac requested review from ripcurlx and sqrrm as code owners Jan 5, 2020
@sqrrm
sqrrm approved these changes Jan 5, 2020
Copy link
Member

sqrrm left a comment

utACK

@sqrrm sqrrm merged commit 25825c4 into bisq-network:master Jan 5, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ripcurlx ripcurlx modified the milestones: v1.2.5, v1.2.6 Jan 7, 2020
@sqrrm sqrrm mentioned this pull request Jan 13, 2020
@ripcurlx ripcurlx added the a:bug label Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.