Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix style issues #3876

Merged
merged 6 commits into from Jan 8, 2020
Merged

Fix style issues #3876

merged 6 commits into from Jan 8, 2020

Conversation

@ripcurlx
Copy link
Member

ripcurlx commented Jan 8, 2020

This will fix a text style issue in the offer book that occurs every now and then depending on the other cell row text colors.
Before
Bildschirmfoto 2020-01-08 um 18 02 58
After
Bildschirmfoto 2020-01-08 um 18 03 03

Also it moves all color codes to the top in the dark mode to be more consistent.

ripcurlx added 2 commits Jan 8, 2020
@ripcurlx ripcurlx requested a review from sqrrm as a code owner Jan 8, 2020
@wiz

This comment has been minimized.

Copy link
Member

wiz commented Jan 8, 2020

Would you mind putting the before and after screenshot of what's changed?

@ripcurlx

This comment has been minimized.

Copy link
Member Author

ripcurlx commented Jan 8, 2020

Added another fix for the small label icon in dark mode

Before
Bildschirmfoto 2020-01-08 um 17 37 29
After
Bildschirmfoto 2020-01-08 um 17 59 11

Copy link
Member

wiz left a comment

You can remove the "(beta)" label now 😂

@ripcurlx

This comment has been minimized.

Copy link
Member Author

ripcurlx commented Jan 8, 2020

Just recognized that the switch icon (fixed/percentage based price) is also not visible in dark mode. My fault: it is visible, just not when taking an existing offer.

ripcurlx added 2 commits Jan 8, 2020
@ripcurlx

This comment has been minimized.

Copy link
Member Author

ripcurlx commented Jan 8, 2020

I had to add back a manual workaround as it wasn't possible to solve it otherwise 😞

@wiz
wiz approved these changes Jan 8, 2020
Copy link
Member

wiz left a comment

ACK

Copy link

RiccardoMasutti left a comment

ACK

cssThemeFolder + "bisq.css",
cssThemeFolder + "images.css",
cssThemeFolder + "CandleStickChart.css",
// load base styles first

This comment has been minimized.

Copy link
@RiccardoMasutti

This comment has been minimized.

Copy link
@sqrrm

sqrrm Jan 8, 2020

Member

It was badly indented before, should be 8 for arguments.

This comment has been minimized.

Copy link
@wiz

wiz Jan 8, 2020

Member

sorry this was one of my early contributions and I had my text editor set to hard tabs or something

@sqrrm
sqrrm approved these changes Jan 8, 2020
Copy link
Member

sqrrm left a comment

utACK

cssThemeFolder + "bisq.css",
cssThemeFolder + "images.css",
cssThemeFolder + "CandleStickChart.css",
// load base styles first

This comment has been minimized.

Copy link
@sqrrm

sqrrm Jan 8, 2020

Member

It was badly indented before, should be 8 for arguments.

@sqrrm sqrrm merged commit 59021e2 into bisq-network:master Jan 8, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ripcurlx ripcurlx added this to the v1.2.5 milestone Jan 9, 2020
@sqrrm sqrrm mentioned this pull request Jan 13, 2020
@RiccardoMasutti RiccardoMasutti mentioned this pull request Jan 13, 2020
@ripcurlx ripcurlx mentioned this pull request Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.