Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix popup message about trade limits #3897

Merged
merged 1 commit into from Jan 16, 2020
Merged

Conversation

@rafaelpac
Copy link
Contributor

rafaelpac commented Jan 13, 2020

When a user tries to take an offer which is above his limit, the old popup is still being shown.
It says that the user limits will be raised when his account is 2 months old.
But that is not true anymore, now we have account signing etc...
This fix uses the string that is already used for offer creation, which is good since preserves translations.
But I think we would need a better message, which I am afraid I cannot get done, showing the sign state and age.
I am submitting this PR as is now since I think this is a big issue.
New users might try to use Bisq to accept an offer, get this message and then decide to wait 2 months, in vain.
So, it partially fixes #3885.

When a user tries to take an offer which is above his limit, the old popup is still being shown.
It says that the user limits will be raised when his account is 2 months old.
But that is not true anymore, now we have account signing etc...
This fix uses the string that is already used for offer creation, which is good since preserves translations.
But I think we would need a better message, which I am afraid I cannot get done, showing the sign state and age.
I am submitting this PR as is now since I think this is a big issue.
New users might try to use Bisq to accept an offer, get this message and then decide to wait 2 months, in vain.
So, it partially fixes #3885.
@rafaelpac rafaelpac requested review from ripcurlx and sqrrm as code owners Jan 13, 2020
@ripcurlx

This comment has been minimized.

Copy link
Member

ripcurlx commented Jan 16, 2020

@rafaelpac Thanks for catching this issue. I think it is good as suggested by you. But yes, both for offer creation and offer taking we could improve the popup taking the current account state into account and making it more tailored to the user account.

Copy link
Member

ripcurlx left a comment

ACK

Tested it locally on Regtest and it works now as expected.

@ripcurlx ripcurlx merged commit a3307da into bisq-network:master Jan 16, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rafaelpac

This comment has been minimized.

Copy link
Contributor Author

rafaelpac commented Jan 17, 2020

Fixes #3247

@ripcurlx ripcurlx added this to the v1.2.6 milestone Jan 21, 2020
@ripcurlx ripcurlx added the a:bug label Feb 4, 2020
@ripcurlx ripcurlx mentioned this pull request Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.