Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove btcnodes not operated by Bisq btcnode team members #3904

Merged
merged 1 commit into from Jan 27, 2020

Conversation

@wiz
Copy link
Member

wiz commented Jan 16, 2020

Background

Due to a change starting from Bitcoin 0.19.x, a non-default bitcoin.conf configuration is now required for usage with Bisq nodes: peerbloomfilters=1 must be set.

Summary

Because of the change in Bitcoin, a Bisq node can no longer use a Bitcoin node with default settings. Therefore, Bisq must ensure that all of its hard-coded Bitcoin nodes have the peerbloomfilters=1 setting enabled.

Currently we have 2 hard-coded Bitcoin nodes whose operators are not members of the #btcnodes team/channel on Keybase or Github, and do not make regular reports to the Bisq DAO. Additionally, we have seen availability issues with these 2 btcnodes in the past, with no way to communicate or coordinate with these btcnode operators.

Because of the above concerns, this PR removes these 2 btcnodes. If the btcnode operators confirm they fulfill the above requirements, they can request to be re-added.

@wiz wiz force-pushed the wiz:remove-third-party-btcnodes branch from 08f94e0 to 9acc17b Jan 19, 2020
@wiz wiz changed the title Remove 2 btcnodes not operated by active bisq contributors Remove btcnodes not operated by Bisq btcnode team members Jan 20, 2020
@wiz wiz marked this pull request as ready for review Jan 20, 2020
@wiz wiz requested a review from ripcurlx as a code owner Jan 20, 2020
@ripcurlx

This comment has been minimized.

Copy link
Member

ripcurlx commented Jan 21, 2020

@jhoenicke @sgeisler I'm tagging you so you can give feedback on this PR before it is merged into master. I'll keep it open for a couple of days to give time to response.

@ripcurlx

This comment has been minimized.

Copy link
Member

ripcurlx commented Jan 27, 2020

Merging this PR because of no response by the node operators (@jhoenicke @sgeisler) for 6 days.

Copy link
Member

ripcurlx left a comment

utACK

@ripcurlx ripcurlx merged commit 525fbe2 into bisq-network:master Jan 27, 2020
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ripcurlx ripcurlx added this to the v1.2.6 milestone Jan 27, 2020
@wiz wiz deleted the wiz:remove-third-party-btcnodes branch Jan 27, 2020
@ripcurlx ripcurlx mentioned this pull request Feb 14, 2020
@wiz wiz mentioned this pull request Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.