Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new BSQ issued v. burnt chart #3910

Merged

Conversation

@dmos62
Copy link
Contributor

dmos62 commented Jan 21, 2020

Depends on following PR: #3890
Relevant issue: #3753

Adds a new two-line chart that plots the month-bucketed BSQ issued and
burnt series. Until now there wasn't a direct visual means of
examining BSQ issue and burn together. This chart aims to fix that.

Screenshot:
bsq issued v  burnt

@dmos62 dmos62 requested review from ripcurlx and sqrrm as code owners Jan 21, 2020
@ripcurlx

This comment has been minimized.

Copy link
Member

ripcurlx commented Jan 27, 2020

@dmos62 I gave it a try locally and I think it would be a good chart to add.
Bildschirmfoto 2020-01-27 um 16 03 18
But I think it would be great if @pedromvpg could give it some design love.
The minimum for me would be to fix the padding between the title and the chart (cuts of the font).
@m52go Could you also suggest/review the title of the chart?

Copy link
Member

m52go left a comment

Two small suggestions.

@ripcurlx

This comment has been minimized.

Copy link
Member

ripcurlx commented Feb 3, 2020

@dmos62 Could you please resolve the conflict and I'll review your PR again for v1.2.6.

@dmos62

This comment has been minimized.

Copy link
Contributor Author

dmos62 commented Feb 3, 2020

dmos62 and others added 3 commits Jan 21, 2020
Adds a new two-line chart that plots the month-bucketed BSQ issued and
burnt series. Until now there wasn't a direct visual means of
examining BSQ issue and burn together. This chart aims to fix that.
Co-Authored-By: Steve Jain <mfiver@gmail.com>
"BSQ issued v. burnt" > "BSQ issued v. BSQ burnt"

Co-Authored-By: Steve Jain <mfiver@gmail.com>
@dmos62 dmos62 force-pushed the dmos62:dao-facts-and-figures-burn-v-issue branch from 8e09970 to 6d3a209 Feb 3, 2020
dmos62 added 2 commits Feb 3, 2020
@dmos62

This comment has been minimized.

Copy link
Contributor Author

dmos62 commented Feb 3, 2020

Force pushed after rebasing onto master and pushed two commits fixing the spacing between title and chart. The spacing is now increased from default by 10d (via Layout.COMPACT_FIRST_ROW_DISTANCE).

bsq issued v  burnt chart margin fixed

Copy link
Member

ripcurlx left a comment

ACK

Tested it against Mainnet and everything looks fine now.
Bildschirmfoto 2020-02-03 um 17 11 02

@ripcurlx ripcurlx merged commit a452a31 into bisq-network:master Feb 3, 2020
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ripcurlx ripcurlx added this to the v1.2.6 milestone Feb 3, 2020
@dmos62 dmos62 mentioned this pull request Feb 8, 2020
@ripcurlx ripcurlx mentioned this pull request Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.