Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused uid in pricefeed service #3937

Merged
merged 1 commit into from Feb 4, 2020
Merged

Conversation

@freimair
Copy link
Member

freimair commented Feb 4, 2020

This came up during work on #3916.

Bisq frequently (once per minute) queries our price nodes for up-to-date
price information. It does so by HTTP GET request. However, it provided
a UID via the "User-Agent" HTTP header field. This UID has been a random
number which changed everytime Bisq got started up.

This UID has never been used. Thus, remove it.

Bisq frequently (once per minute) queries our price nodes for up-to-date
price information. It does so by HTTP GET request. However, it provided
a UID via the "User-Agent" HTTP header field. This UID has been a random
number which changed everytime Bisq got started up.

This UID has never been used. Thus, remove it.
@ripcurlx ripcurlx requested a review from wiz Feb 4, 2020
Copy link
Member

ripcurlx left a comment

utACK

@wiz
wiz approved these changes Feb 4, 2020
Copy link
Member

wiz left a comment

This is great for privacy 👍

@ripcurlx ripcurlx merged commit d6de99c into bisq-network:master Feb 4, 2020
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ripcurlx ripcurlx added this to the v1.2.6 milestone Feb 4, 2020
@ripcurlx ripcurlx mentioned this pull request Feb 14, 2020
@wiz

This comment has been minimized.

Copy link
Member

wiz commented Feb 18, 2020

pricenode still has UUID in logs

INFO  b.p.m.FeeRateController: Incoming /getFees request from: bisq/1.2.7, uid:f33c97d1-b065-48c4-bc84-eaaa680e4288
@freimair

This comment has been minimized.

Copy link
Member Author

freimair commented Feb 18, 2020

I only focused on the stuff relevant to the networksize metric. I guess we can remove the uid for the getFee stuff as well. However, I will not touch the mobile notification stuff because I do not know how these things work in detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.