Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signing debug logs #3948

Merged
merged 2 commits into from Feb 7, 2020
Merged

Add signing debug logs #3948

merged 2 commits into from Feb 7, 2020

Conversation

@sqrrm
Copy link
Member

sqrrm commented Feb 6, 2020

Fix warning about possible nullpointer exceptions. Better to have an
explicit check for debug purposes.

Smaller cleanups

I'm chasing a possible bug where some traders are not getting signed after a trade that looks like it should result in a signed account. These logs will help to add some more helpful info for getting .to the issue

sqrrm added 2 commits Feb 6, 2020
Fix warning about possible nullpointer exceptions. Better to have an
explicit check for debug purposes.

Smaller cleanups
@ripcurlx

This comment has been minimized.

Copy link
Member

ripcurlx commented Feb 7, 2020

@sqrrm Shall we add this to this release to get more information on this as soon as possible?

@ripcurlx ripcurlx added the is:priority label Feb 7, 2020
@sqrrm

This comment has been minimized.

Copy link
Member Author

sqrrm commented Feb 7, 2020

Yes, would be good to get it in the release to start getting some hints of what's going on.

Copy link
Member

ripcurlx left a comment

ACK

Tested it on Regtest and it logged following during a test trade

Feb.-07 15:53:56.638 [JavaFX Application Thread] INFO  b.c.a.w.AccountAgeWitnessService: AccountSigning: 
tradeId: ZJEYLNV-7b505b13-6df6-4777-beb4-e18ee130a4cb-125
is buyer: true
buyer account age witness info: UNSIGNED Not signed yet
Optional[AccountAgeWitness{
     hash=b8d43b8509ee96bf1e8c82056fc5268ce3b645c1,
     date=2019-11-22T09:12:50.779Z
}]
seller account age witness info: ARBITRATOR signed by an arbitrator and can sign peer accounts
Optional[AccountAgeWitness{
     hash=85286fcdddb138bfebbd0abb5f87b95d04aff642,
     date=2019-11-22T09:03:30.483Z
}]
checking for sign trade: false
is myWitness signer: false
peer has signed witness: true
trade amount: 1000000
trade amount is sufficient: true
isSignWitnessTrade: false
@ripcurlx ripcurlx merged commit ac7d636 into bisq-network:master Feb 7, 2020
4 checks passed
4 checks passed
greeting
Details
label
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ripcurlx ripcurlx added this to the v1.2.6 milestone Feb 7, 2020
@sqrrm sqrrm mentioned this pull request Feb 10, 2020
@ripcurlx ripcurlx mentioned this pull request Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.