Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept empty config values #3978

Merged
merged 1 commit into from Feb 17, 2020
Merged

Conversation

@ripcurlx
Copy link
Member

ripcurlx commented Feb 17, 2020

Fixes #3977.

Fixes #3977.
@ripcurlx ripcurlx requested a review from cbeams Feb 17, 2020
@ripcurlx ripcurlx mentioned this pull request Feb 17, 2020
@sqrrm
sqrrm approved these changes Feb 17, 2020
Copy link
Member

sqrrm left a comment

ACK

@sqrrm sqrrm merged commit c411f48 into bisq-network:master Feb 17, 2020
4 checks passed
4 checks passed
greeting greeting
Details
label
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Copy link
Member

cbeams left a comment

ACK. This is after the fact of merging, but still thought I'd mention that the change is appropriate from my side. It's a good catch; I was simply unaware of this bit from the Javadoc for String#split:

[...] Trailing empty strings are therefore not included in the resulting array.

@ripcurlx ripcurlx added this to the v1.2.8 milestone Feb 26, 2020
@sqrrm sqrrm mentioned this pull request Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.