Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false deletion of hsdir when using --appDataDir #4018

Merged
merged 1 commit into from Mar 7, 2020

Conversation

@freimair
Copy link
Member

freimair commented Feb 28, 2020

Probably fixes #3995

There are circumstances where input via --appDataDir
will lead to the hiddenservice-directory to be deleted.
Successfully reproduced using

--appDataDir=~/foo

Although the "~" does not get interpreted correctly on
my linux system, it does manage to throw off the
mechanics of sparing the hiddenservice-directory from
being deleted on startup.

There are circumstances where input via --appDataDir
will lead to the hiddenservice-directory to be deleted.
Successfully reproduced using

  --appDataDir=~/foo

Although the "~" does not get interpreted correctly on
my linux system, it does manage to throw off the
mechanics of sparing the hiddenservice-directory from
being deletd.
@freimair freimair force-pushed the freimair:fix_hsdir_getting_deleted branch from 46c16c7 to 0b7788a Mar 4, 2020
@freimair freimair marked this pull request as ready for review Mar 4, 2020
@sqrrm
sqrrm approved these changes Mar 7, 2020
Copy link
Member

sqrrm left a comment

utACK

@sqrrm sqrrm merged commit 4c3a562 into bisq-network:master Mar 7, 2020
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ripcurlx ripcurlx added this to the v1.2.8 milestone Mar 9, 2020
@ripcurlx ripcurlx added the is:priority label Mar 9, 2020
@freimair freimair mentioned this pull request Mar 11, 2020
@sqrrm sqrrm mentioned this pull request Mar 11, 2020
@freimair freimair deleted the freimair:fix_hsdir_getting_deleted branch Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.