Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update offer address to new hidden service files #4021

Merged
merged 3 commits into from Mar 10, 2020

Conversation

@freimair
Copy link
Member

freimair commented Mar 2, 2020

motivated by and fixes #3995, at least its symptoms

When the hiddenservice address changes, offers now get updated to the new address before republishing. If there are open trades, they will still fail but at least there are no faulty offers out there anymore. Plus, a user might wonder why nobody takes his offers.

Happens if Bisq silently starts a fresh hiddenservice. Reasons for that to happen might be:

  • hidden service files get damaged (example)
  • antivirus software deleting hidden service files
  • #3884
  • support tells them to do so to fix network connectivity issues
freimair added 3 commits Feb 28, 2020
@freimair freimair changed the title Update offer address on clean Update offer address to new hidden service files Mar 3, 2020
@freimair freimair marked this pull request as ready for review Mar 3, 2020
@wiz
wiz approved these changes Mar 4, 2020
Copy link
Member

wiz left a comment

ACK
tested okay by creating offer, deleting tor key, and saw "updated" log print - offers are now takable on the new onion address

Copy link
Member

ripcurlx left a comment

utACK

@ripcurlx ripcurlx merged commit 6d457e4 into bisq-network:master Mar 10, 2020
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ripcurlx ripcurlx added this to the v1.2.8 milestone Mar 10, 2020
@ripcurlx ripcurlx mentioned this pull request Mar 16, 2020
@freimair freimair deleted the freimair:update_offer_address_on_clean branch Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.