Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dump failed delayedtx #4029

Merged
merged 2 commits into from Mar 9, 2020
Merged

Dump failed delayedtx #4029

merged 2 commits into from Mar 9, 2020

Conversation

@sqrrm
Copy link
Member

sqrrm commented Mar 5, 2020

Dump delayed payout txs of both pending and failed trades if the flag is set.

sqrrm added 2 commits Mar 5, 2020
@sqrrm sqrrm requested review from ripcurlx and wiz Mar 5, 2020
Copy link
Member

wiz left a comment

Tested but unfortunately all the payout TX were null

[
  {
    "tradeId": "xxx",
    "delayedPayoutTx": "null"
  }
]
@ripcurlx

This comment has been minimized.

Copy link
Member

ripcurlx commented Mar 9, 2020

Tested but unfortunately all the payout TX were null

[
  {
    "tradeId": "xxx",
    "delayedPayoutTx": "null"
  }
]

I guess that depends on why this trades were moved into the failed trades section. For my two failed trades on Regtest it did work as expected.

[
  {
    "tradeId": "09129192-ecda2d7e-36d6-4a3b-b875-05579b949504-123",
    "delayedPayoutTx": "01000000011db2d865d7ab4dc0de3cb0dc3f1a02738a69c401f86e68d0ecec08bc58611e7500000000d9004730440220175123ac7f010403036a5d5ef82ae976c9d32dbfe4996c83f869911796dfc1cb022041459fc5595366cdc925d0c669ebebb33f49038a95e6e0ef5d15abd22bdeb5000147304402203377ae1671ed1a5adfc73dff46033baaa71dc5c198075c17646cdf9b20bef4dd0220553c92ea2529ed06c123b636cc0890817010d538dcf3e8a6ab6e1d1156dce2b001475221033498e43bca79880e30e3ee7a3bfaea21d1f1a7a85479a9e38da72763654ad66d2103ab14b9ac8e39d3a55e66ae2e3a33a9bce1d690d3d706a4c21284619db0f789f352aefeffffff01e079af000000000017a9144c0e4893237f85479f489b32c8ff0faf3ee2e1c987ee000000"
  },
  {
    "tradeId": "nf7JKDk-fd937755-bd91-40c3-865f-3a50637e3b16-124",
    "delayedPayoutTx": "0100000001227c2b78e625506d8e0599eadc3ee59037a8493644e28bdfcc624eaaafb8ece200000000d900473044022023389189dd495b4d88edd23578c6f3dcca7083ea14bcfceaf6ef13eae7fd124602202a88ce335ed2727e41451037875b0dd1329f75907709962edab8552363842edb01473044022016ac85fe3f3c41945e9049a04d50ad95fe1a17b379ad6c6c27cb6da436cb14c002207a3b53ae5cb0f7e56a1b5c2beddc6e2bba279bf0c7efef87409503f539f3501501475221030eee4885aa68721780a62568ba297764214c731b66d1e352fcb2eb952865f4d921024a694567b72d84480eb60b73dc5eb2a48a27a4f523bc3d84ed47535633377c3c52aefeffffff01c09121000000000017a9144c0e4893237f85479f489b32c8ff0faf3ee2e1c9870d010000"
  }
]
Copy link
Member

ripcurlx left a comment

ACK

Tested it locally on Regtest with two failed trades #4029 (comment)

@ripcurlx ripcurlx merged commit 698716d into bisq-network:master Mar 9, 2020
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ripcurlx ripcurlx added this to the v1.2.8 milestone Mar 9, 2020
@ripcurlx ripcurlx added the is:priority label Mar 9, 2020
@sqrrm sqrrm mentioned this pull request Mar 11, 2020
@ripcurlx ripcurlx mentioned this pull request Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.