Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce CoinMarketCap stub to prevent error in existing clients #4037

Merged
merged 2 commits into from Mar 9, 2020

Conversation

@ripcurlx
Copy link
Member

ripcurlx commented Mar 9, 2020

No description provided.

@ripcurlx ripcurlx requested a review from cbeams as a code owner Mar 9, 2020
Copy link
Member

sqrrm left a comment

utACK

Copy link
Member

wiz left a comment

ACK
seems working as I have the CMC placeholder now
http://gztmprecgqjq64zh.onion/getAllMarketPrices

@ripcurlx ripcurlx dismissed stale reviews from wiz and sqrrm via 537f3d4 Mar 9, 2020
@sqrrm
sqrrm approved these changes Mar 9, 2020
Copy link
Member

sqrrm left a comment

ACK

Tested by running local client against wiz's pricenode running this version

@sqrrm sqrrm merged commit 6a27ab0 into bisq-network:master Mar 9, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sqrrm sqrrm mentioned this pull request Mar 11, 2020
@ripcurlx ripcurlx mentioned this pull request Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.