Fix popup window ordering problem #4360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a race condition in PopupManager when with a stack of 2 popups, the top popup is being replaced by another top-level popup. The base layer popup ends up on top of the z-order, obscuring the correct one. The race condition in PopupManager was within the onHidden() method which invokes the next window in the queue. The call to displayNext() needs to be asynchronous so that a newer popup can take precedence. Fixes bisq-network#4293
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a race condition in PopupManager when with a stack of 2 popups, the top popup is being replaced by another top-level popup. The base layer popup ends up on top of the z-order, obscuring the correct one.
The race condition in PopupManager was within the onHidden() method which invokes the next window in the queue. The call to displayNext() needs to be asynchronous so that a newer popup can take precedence.
Fixes #4293