Always include high prio payload in get data response #6501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add default getGetDataResponsePriority impl. to NetworkPayload Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
HenrikJannsen
force-pushed
the
always_include_high_prio_payload_in_get_data_response
branch
from
bb1680a
to
0822515
Compare
Fix sorting at truncating DateSortedTruncatablePayloads. Rebroadcast high prio items
HenrikJannsen
force-pushed
the
always_include_high_prio_payload_in_get_data_response
branch
from
66d2caf
to
7db8255
Compare
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
Sorry I don't have time atm to fix the complex tests. In the past the issues have always been caused by test setup issues and not because of introduced bugs. Here we changed the algorithm for truncation, so that might be the case why it fails, or it is the new method for priority which might cause issues with the mocks. Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
jmacxx
approved these changes
Jan 11, 2023
There was a problem hiding this comment.
ACK
Small request - can logging of monitor sends be removed?
e.g. Going to send report to monitor server
e.g. Sent successfully report to monitor server with 1 items
Jan-11 13:53:40.297 [ForkJoinPool.commonPool-worker-1] INFO b.s.r.SeedNodeReportingService: Sent successfully report to monitor server with 1 items
Jan-11 13:53:40.312 [ForkJoinPool.commonPool-worker-1] INFO b.s.r.SeedNodeReportingService: Sent successfully report to monitor server with 1 items
Jan-11 13:53:40.316 [SeedNodeMain] INFO b.s.r.SeedNodeReportingService: Going to send report to monitor server: [GetProposalStateHashesRequest=15]
Jan-11 13:53:40.316 [SeedNodeMain] INFO b.c.d.m.n.StateNetworkService: Send GetProposalStateHashesResponse with 5 stateHashes to peer Optional[pfps6t4rdvaut7ivmaf72w7rh4q2credibm32bdkn3c5catazal5blyd.onion:9999]
Jan-11 13:53:40.318 [SeedNodeMain] INFO b.s.r.SeedNodeReportingService: Going to send report to monitor server: [GetProposalStateHashesResponse=2]
Jan-11 13:53:40.336 [SeedNodeMain] INFO b.s.r.SeedNodeReportingService: Going to send report to monitor server: [GetBlindVoteStateHashesRequest=20]
Jan-11 13:53:40.336 [SeedNodeMain] INFO b.c.d.m.n.StateNetworkService: Send GetBlindVoteStateHashesResponse with 5 stateHashes to peer Optional[pfps6t4rdvaut7ivmaf72w7rh4q2credibm32bdkn3c5catazal5blyd.onion:9999]
Jan-11 13:53:40.337 [SeedNodeMain] INFO b.s.r.SeedNodeReportingService: Going to send report to monitor server: [GetBlindVoteStateHashesResponse=2]
Jan-11 13:53:40.416 [ForkJoinPool.commonPool-worker-1] INFO b.s.r.SeedNodeReportingService: Sent successfully report to monitor server with 1 items
Jan-11 13:53:40.417 [ForkJoinPool.commonPool-worker-1] INFO b.s.r.SeedNodeReportingService: Sent successfully report to monitor server with 1 items
Jan-11 13:53:40.426 [ForkJoinPool.commonPool-worker-1] INFO b.s.r.SeedNodeReportingService: Sent successfully report to monitor server with 1 items
Jan-11 13:53:40.427 [ForkJoinPool.commonPool-worker-1] INFO b.s.r.SeedNodeReportingService: Sent successfully report to monitor server with 1 items
HenrikJannsen
deleted the
always_include_high_prio_payload_in_get_data_response
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issues when at the first getDataRequests data are truncated and Filter object (or support agents) are mission, leading to a warning popup. At repeated Getdata requests we get the data but its confusing to the user to see those popups and it would be better to get the high priority data guaranteed at the start.