Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For August 2018 #110

Closed
chirhonul opened this issue Aug 30, 2018 · 4 comments

Comments

Projects
None yet
4 participants
@chirhonul
Copy link
Member

commented Aug 30, 2018

Summary

Specify the total amount of BSQ you are requesting, and the BSQ address that amount should be paid to:

  • BSQ requested: 5000
  • BSQ address: B197ZcX369usMDHCF6iD2h1CMbntkovDqoe

This is my first compensation request. I have talked about some of the details of the process
with @ManfredKarrer, who I also collaborated closely with during most / all of the work. Please
let me know if the requested BSQ amount is unreasonable, or if there's other suggestions for
how I can file better reports in the future!

Contributions delivered

Provide links to contributions you have delivered, the amount of BSQ you are requesting for each, and any comments that will help stakeholders understand
its value.

I am requesting 2000 BSQ for the dev work and 3000 BSQ for the conceptual discussion and feedback.

DAO development

My development work that was shipped with the v0.8.0 release focused mainly on simplifying and hardening code and tests, as well as other engineering to improve the odds that it behaves as expected for the DAO:

  • add and expand unit test coverage
  • simplify implementation
  • using defensive coding, verify supposed invariants
  • refactor code to be placed in more appropriate packages
  • improve comments and code style
  • remove dead code

I'm listing the commits that were merged, which all were in the bisq-core repo, below. I am aware that most contributors link to PRs instead of individual commits, but the commits themselves are better places to document the work in my opinion since they persist even if we move away from github.com in the future.

List of commits:

The DAO code has been shipped to users, and even though it is disabled by default I am requesting
compensation for the code included in the v0.8.0 release, as suggested by @ManfredKarrer.

Conceptual discussion and feedback for the DAO

Beyond the pure code contributions, I have also had many discussions with @ManfredKarrer on the topic of the DAO, e.g:

  • testing and other reliability engineering strategies before going to mainnet
  • conceptual discussion / feedback on e.g the merit proposal, the offchain trade protocol using bonding
  • observations and suggestions on the high-level structure of the bisq repos and packages

Most of these discussions were either offline or in private chat, so it's hard to link to
concrete items..

There's additionally various earlier suggestions for changes, reviews and so on that happened before Aug, like bisq-network/bisq-core#124, but I am not planning to list all of them.

Roles performed

Provide links to your monthly report on any roles you are responsible for.

None so far.

@ManfredKarrer

This comment has been minimized.

Copy link
Member

commented Aug 30, 2018

Thanks for the request!

As you mentioned I suggested to add the request already now and not to wait until the DAO code is enabled and on mainnet.

I just added a proposal for discussing that topic:
bisq-network/proposals#38

@cbeams I am sorry that we did not start the discussion earlier, too much things going on...

@HarryMacfinned

This comment has been minimized.

Copy link

commented Aug 31, 2018

Thanks for helping on the dev and strengthening code.
I'm happy to see one more dev here.

One little suggestion:
Maybe you could separate the technical report from the compensation request itself. I think it was a @cbeams advice, and I find that doubly helpful, for the writer, and for the readers.

@ripcurlx

This comment has been minimized.

Copy link
Member

commented Sep 4, 2018

Closing as complete, see #107 (comment)

@ripcurlx ripcurlx closed this Sep 4, 2018

@chirhonul

This comment has been minimized.

Copy link
Member Author

commented Sep 9, 2018

Maybe you could separate the technical report from the compensation request itself. I think it was a @cbeams advice, and I find that doubly helpful, for the writer, and for the readers.

Thanks for the suggestion @HarryMacfinned! I will consider that next time.. for last month, there were no github issues describing the specific technical projects (general reliability engineering in preparation for the DAO, mostly) so I'm not sure where the best place would be for the more technical work in this case..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.