Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cycle4 #329

Closed
christophsturm opened this issue Aug 8, 2019 · 0 comments
Closed

cycle4 #329

christophsturm opened this issue Aug 8, 2019 · 0 comments

Comments

@christophsturm
Copy link

christophsturm commented Aug 8, 2019

Summary

Specify the total amount of BSQ you are requesting:

  • BSQ requested: 7000

Contributions delivered

Provide links to contributions you have delivered, the amount of BSQ you are requesting for each, and any comments that will help stakeholders understand its value.

the main topic of my first weeks in the world of bisq was making the project more welcoming to newcomers, untangle some code and work on stability.

bisq-network/bisq#2997
Fix a logging bug that resulted in a lost stacktrace for some errors which made it impossible to find the exact location of an exception

bisq-network/bisq#3005
split up the java files that protobuf generates.
Idea was basically unusable and very slow because of the huge pb.java file. also we needed special flags in the idea config to get it to even work at all. Now this is fixed, idea is snappy again and its also easier for newcomers to get the project to build

bisq-network/bisq#3004
fix a logging bug

bisq-network/bisq#3024 and bisq-network/bisq#3023
make it totally clear that only jdk10 is supported. the default jdk that people have now is jdk 12. with jdk 12 some tests fail and its not clear that its because of the jdk. so i changed the gradle build to fail with a useful error message when the jdk is wrong, and also added information to the readme how to get jdk10.

bisq-network/bisq#3007
make sure fields that are deprecated in protobuf are also deprecated in the generated java code.

bisq-network/bisq#3030
I cherry picked as much code as possible from an older stale pr into master to give the account signing project more momentum

bisq-network/bisq#2999, bisq-network/bisq#3034 and bisq-network/bisq#3037
test improvements for account signing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant