Adds support for IOTA altcoin: https://iota.org/ #929
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Bitsquare.iss
…garding chargeback risk and id verification. Add warning to CXC accounts.
…named to Bisq -> we rename the app data dir).
Update AUR link
…: guava, jackson-annotations.
… and move protobuf-util to common like the other protobuf dependency. Also make it visible outside of test
the lines
SetupIconFile={localappdata}\Bisq.ico
UninstallDisplayIcon={localappdata}\Bisq.ico
are wrong, Bisq folder is located in {localappdata} and the icons are inside Bisq\ path
so a more coherent change would be
SetupIconFile={localappdata}\Bisq\Bisq.ico
UninstallDisplayIcon={localappdata}\Bisq\Bisq.ico
but even this would be wrong since SetupIconFile directive as it is used on compile time only and should contain the absolute path to the icon
Update Bisq.iss
…c initializer to SeedNodeMain, ProviderMain and StatisticsMain
Update displayStrings.properties
A new version (v3.0.0-M1) of the enforcer plugin was released on July 27th. If for whatever reason that new version ends up in the local ~/.m2 cache, it results in broken builds because the new version's checksum gets validated instead of the older v1.4.1 checksum being validated. This is because the version provided to check was set simply to 'RELEASE', i.e. an alias indicating "whatever the latest release happens to be". This commit fixes #897 and avoids these potential build failures by pinning the version explicitly to v1.4.1. This forces the correct checksum to get validated, in turn causing the build to pass as expected.
Previously every successful build was triggering a notification to be sent to Slack, and this is too noisy.
This change removes the need to clone and build bisq's forks of bitcoinj, libdohj and btcd-cli4j in order to build bisq itself.
# Conflicts: # doc/build.md
…idator and AltCoinAddressValidatorTest and 2 specific classes: PNCAddressValidator and PNCParams.
Add new altcoin with code "PNC"
|
This is not a correct PR. |
|
Will you add it to the next version? Would be nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for IOTA altcoin: https://iota.org/