Skip to content

Bisq Monero Wallet #110

Closed
Closed
@niyid

Description

@niyid

This is a Bisq Network proposal. Please familiarize yourself with the submission and review process.

CC: @ManfredKarrer, @HarryMacfinned, @ripcurlx

Dear All,

This proposal is related to:

CYCLE 6: PROJECT INITIATION

Taking it forward and as suggested by @ManfredKarrer, the user will be responsible for running monerod locally or setting up a remote Monero node via Tor (or any remote Monero node for that matter via Tor). Of course the user will be able to either select a local Monero node (monerod running on localhost) or a remote Monero node via Tor in User Preferences.

The wallet will be accessible at Account > Wallets > Monero. The Wallets screen will allow future support for other wallets.

The Monero wallet will be based on the monero-java-rpc library and support basic functionality as follows:

  • Create (or connect to) a wallet that uses a monero-wallet-rpc endpoint with authentication
  • Get wallet balance as BigInteger/long (for consistency in Bisq use long)
  • Get wallet primary address
  • Get address and balance of sub0-address [1, 0]
  • Get incoming and outgoing transfers
  • Get incoming transfers to account 0
  • Send to an address from account 0
  • Get all confirmed wallet transactions
  • Send to multiple destinations from multiple sub-addresses in account 1 which can be split into multiple transactions
  • Get a wallet transaction by id

Non-basic functionality and integration into Bisq are:

  • Automatically send/receive Monero from/to the wallet to in trading involving Monero.
  • Proof verification for Monero transactions.

ADDENDUM: screenshots with latest build below.

SCREENSHOTS - LATEST MERGED BUILD

Screenshot from 2019-09-18 06-59-35
Screenshot from 2019-09-18 07-00-13
Screenshot from 2019-09-18 07-00-35
Screenshot from 2019-09-18 07-01-05
Screenshot from 2019-09-18 07-01-34

CYCLE 7: MILESTONES & FINANCIAL ESTIMATES

The milestones and cost estimates are as show in the attached below.

Screenshot from 2019-10-21 02-53-00

Proposal_110_Milestones.xlsx

The trade interface mentioned in the spreadsheet is as shown below with the 4 trading steps.

Screenshot from 2019-10-17 23-46-24

The interface will change in line with the suggestion in issue #3375: there will be two top level menus to replace the current Buy BTC and Sell BTC - Buy/Sell BTC (merger of the two foregoing current trade menus) and Buy/Sell XMR (the addition to cater to Monero).

Trading fee calculations will remain consistent with those in current use.

I look forward to your comments.

UPDATE

Keeping in line with protocol v1.2.0, the multisig functionality will now be 2/2 and not 2/3.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions