Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ Propose how to make Bisq nodes serve as Lightning Network nodes using ACINQ's Eclair library ⚡️ #3

Closed
cbeams opened this issue Jan 27, 2018 · 5 comments

Comments

@cbeams
Copy link
Member

cbeams commented Jan 27, 2018

Bisq nodes are long-running. Lightning nodes are too. Why not have Bisq nodes become the simplest form of Lightning node now, as a first step toward deeper kinds of integration later?

To claim this bounty, write a proposal about how to integrate @ACINQ's Scala LN implementation into Bisq such that Bisq nodes automatically participate not only in the Bisq Network for the purpose of buying and selling bitcoin, but also participate in the Lightning Network for the purpose of routing payments.

Bisq users could benefit from even the most basic LN integration immediately because their already-running Bisq nodes would begin to earn fees for routing LN payments. These fees may be very small, but Bisq users were going to be running their nodes anyway; it's all profit from their point of view. And besides, most Bisq users would likely be happy to get involved with and help support Lightning however they can. How better to do that than with the app they're already running?

Later, deeper integrations could allow Bisq users to send and receive LN payments of their own, and eventually turn Bisq into a full-fledged Lightning wallet; yet further work could go on to integrate Lightning directly into Bisq's trading protocol.

The proposal being called for here is about devising the best way to get started while keeping these larger ambitions in mind. The proposal itself is the bounty: come up with a cogent plan that gets rough consensus from existing Bisq DAO stakeholders and the reward is yours. Work alone or with others—anyone and everyone can submit a compensation request for the proposal, according to the value they contributed to it.

The work to implement the proposal would be managed as separate issues and separate bounties. The goal is to break work up such that small but meaningful chunks of LN integration can be shipped with each Bisq release.

This work is something we've been thinking about doing for a while, but the existing group of @bisq-network/contributors is busy with other priorities. Ideally, we're looking for new contributors to get involved with Bisq for this effort, and to work as autonomously as possible to propose and then implement this functionality.

If you're interested in and able to do this work, please say so in the comments and add your ideas. Ideally a small team would form to take this on. The proposal process need not be too formal. It can start as a discussion here, and eventually a BIP-style doc can be submitted to this repository as a pull request. Or, if the plan is already clear enough, it can be mapped out into a series of issues in the bisq-network/exchange repository.

@cbeams cbeams changed the title ⚡️ Propose how to make Bisq nodes also serve as Lightning Network nodes using ACINQ's Eclair library ⚡️ ⚡️ Propose how to make Bisq nodes serve as Lightning Network nodes using ACINQ's Eclair library ⚡️ Jan 27, 2018
@ruboots
Copy link

ruboots commented Jan 27, 2018

Probably a simple matter of importing the eclair jars and invoking Setup.boot to get a new "Kit" API.

see: line 101 https://github.com/ACINQ/eclair/blob/6142d92cc189dbc63f4118e349f5bcd30349e565/eclair-core/src/test/scala/fr/acinq/eclair/integration/IntegrationSpec.scala

@citkane

This comment has been minimized.

@citkane

This comment has been minimized.

@cbeams
Copy link
Member Author

cbeams commented Apr 6, 2018

Closing as inactive. This got a lot of 👍's but ultimately no discrete proposal was offered for how to integrate Eclair within Bisq as it is today. If someone would like to re-open this or, perhaps preferably, to open a new proposal about this, please do. It's worth noting here that @ACINQ just shipped their first mainnet-ready Eclair release.

And in case someone does re-open this (or open a new proposal), please see the guidance on proposals I've just put together in #11. The goal of a proposal around integrating Eclair would be to put together a brutally minimal approach to running a lightning node within the same process as a running Bisq node, for the purpose of (a) earning fees and (b) generally supporting the Lightning network. Any such integration should be bare-bones to start with. Indeed that's exactly what we're looking for in such a proposal: what is the simplest integration that could possibly work for making a Bisq node serve double-duty as a Lightning node?

@LeadManPL
Copy link

3 years passed since this proposal, maybe there is some new solution that would easily allow to run BISQ with Lightning Network?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants