Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Bisq's fiat trade limits #71

Closed
HarryMacfinned opened this issue Feb 10, 2019 · 4 comments

Comments

Projects
None yet
2 participants
@HarryMacfinned
Copy link

commented Feb 10, 2019

This is a Bisq Network proposal. Please familiarize yourself with the submission and review process.

We have quite often users complaining about the trade fiat limits being too low.
And maybe many users who say nothing but simply trade less (or stop ?).

I also had a look on the number of trades trend (which is decreasing).

BTC value is roughly half than one or two years ago.
I wonder if it should not be time for Bisq to update the trade limits accordingly ?

@ManfredKarrer

This comment has been minimized.

Copy link
Member

commented Feb 11, 2019

Yes I agree basically, just not sure if it can be easily changed without breaking backward compatibility. I will have a look soon into it, if that is an issue. If I don't follow up here feel free to remind me....

@ManfredKarrer

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

I checked the code and it seems it is possible without any major issues. I will make a PR for doubling the limits.

@HarryMacfinned

This comment has been minimized.

Copy link
Author

commented Feb 12, 2019

I just want to point that updating will not mind making limits higher (as evaluated in fiat money, eg USD or EUR)
If we update by doubling the BTC limits,
in USD or EUR, this will simply mean bring Bisq back on the same limit as 1 or 2 years ago, when BTC value was double than today.

@ManfredKarrer

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

Implemented:

  • Set max trade limit to 2 BTC (for altcoins)
  • Add MAX_TRADE_LIMIT to Param (can be changed in DAO voting)
  • Round first month trade limit to ensure we stick with precision 4 for
    the btc amount
  • Use risk factors to derive trade limits for different payment method
    risk categories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.