Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bisq Maintainer #63

Open
cbeams opened this issue Jan 8, 2018 · 66 comments
Open

Bisq Maintainer #63

cbeams opened this issue Jan 8, 2018 · 66 comments
Assignees
Labels

Comments

@cbeams
Copy link
Member

@cbeams cbeams commented Jan 8, 2018

Docs: https://bisq.wiki/Bisq_Maintainer
Team: @bisq-network/bisq-maintainers

@cbeams

This comment has been hidden.

@cbeams

This comment has been hidden.

@ripcurlx
Copy link
Member

@ripcurlx ripcurlx commented May 31, 2018

2018.05 report

Reviewing and merging of PRs and release preparations for v0.7.0

/cc bisq-network/compensation#71

@ripcurlx
Copy link
Member

@ripcurlx ripcurlx commented Jun 29, 2018

2018.06 report

Reviewing and merging of PRs and release preparations for v0.7.1

/cc bisq-network/compensation#84

@cbeams cbeams mentioned this issue Jun 30, 2018
6 of 6 tasks complete
@cbeams
Copy link
Member Author

@cbeams cbeams commented Jun 30, 2018

2018.06 report

Nothing to report. Note that I plan to remove myself from the set of desktop maintainers.

/cc bisq-network/compensation#89

@cbeams
Copy link
Member Author

@cbeams cbeams commented Jul 3, 2018

@ripcurlx wrote

Reviewing and merging of PRs

I think it's important that we account separately for maintainer work and PR review work. I've written about this in the WIP Roles doc, see https://deploy-preview-46--bisq-docs.netlify.com/roles.html#maintainer. I'm +1'ing your compensation request as-is, but something to keep in mind as you review that doc.

@cbeams
Copy link
Member Author

@cbeams cbeams commented Jul 3, 2018

I've updated the @bisq-network/desktop-maintainers team and the description of this issue to reflect that @ManfredKarrer and @ripcurlx are Bisq Desktop maintainers now, and that I've removed myself.

@ripcurlx
Copy link
Member

@ripcurlx ripcurlx commented Jul 6, 2018

@cbeams Regarding PR reviewer work. Should this be part of the general contributions delivered section in a compensation request referencing PRs reviewed?

@ripcurlx
Copy link
Member

@ripcurlx ripcurlx commented Oct 24, 2020

Cycle 18 report

We pre-released v1.4.0, v1.4.1 and publicly released v1.4.2.
Besides taking care of issues together with @cd2357, who got the triage permission for the Bisq repository recently, I mainly worked on our upcoming build system to be able to switch to a LTS Java version and most up-to-date JavaFX version.

/cc bisq-network/compensation#704

@sqrrm
Copy link
Member

@sqrrm sqrrm commented Nov 26, 2020

Cycle 19 report

There was a lot of work to get 1.5.0 released with all the issues we had with 1.4.2. So far 1.5.0 seems to be at least not worse than 1.4.2 which is a good thing. There are still quite a lot of support cases lingering from 1.4.2 so I would consider stronger incentives for users to upgrade if we don't get a good uptake.

bisq-network/compensation#721

@ripcurlx
Copy link
Member

@ripcurlx ripcurlx commented Nov 26, 2020

Cycle 19 report

We released v1.5.0 without a pre-release phase as it is not possible to trade with older versions because of the trade protocol changes. Also we wanted to get the bug fixes introduced in v1.4.2 out there as soon as possible. We do have a 70%+ adoption rate of v1.5.0 already, so I hope support cases should decrease soon. I do check now on a daily basis all GitHub notifications to react in-time on issues and PR changes to prevent unnecessary blocks from maintainers side.

/cc bisq-network/compensation#723

@ripcurlx
Copy link
Member

@ripcurlx ripcurlx commented Dec 28, 2020

Cycle 20 report

Although we fixed with v1.5.1 already most of the issues experienced in v1.5.0, v1.5.2 shipped as a regular release should finally bring some calm over the holidays into mediation and support (hopefully).

I continue to check on a daily basis all GitHub notifications to react in-time on issues and PR changes to prevent unnecessary blocks from maintainers side. Over the holidays I wasn't able to deliver on this, but I'll try my best to clean out my notifications log today.

[EDIT]
I did forget to mention that I had to renew my Code Signing Certificate for Windows for €91.55 (~$111). I'll add this to the desktop maintainer amount.
[/EDIT]

/cc bisq-network/compensation#746

@sqrrm
Copy link
Member

@sqrrm sqrrm commented Dec 28, 2020

Cycle 20 report

A fair few issues going on from the previous releases which added to the review and merge workload. Reviews are in general reported separately but there is an overhead of having to monitor PRs and handling the releases.

bisq-network/compensation#747

@sqrrm
Copy link
Member

@sqrrm sqrrm commented Jan 27, 2021

Cycle 21 report

Voting in last cycle failed which so far caused less problems than I would've expected. The DAO code worked as expected and contributors have been very good about it.

bisq-network/compensation#773

@ripcurlx
Copy link
Member

@ripcurlx ripcurlx commented Jan 29, 2021

Cycle 21 report

We released v1.5.3 and v1.5.4 as a hotfix release as we experienced behavior that looked like a DoS attack. Since those two releases everything is working again (except the TOR related issues every now and then, which are based on a real DoS attack).

/cc bisq-network/compensation#758

@ripcurlx
Copy link
Member

@ripcurlx ripcurlx commented Mar 2, 2021

Cycle 22 report

We released v1.5.5, v1.5.6 of , v1.5.7, v1.5.8, and v1.5.9. v1.5.6 was a hotfix that fixed startup issues for limit offers, v1.5.8 was a follow-up release introducing dynamic min tx fee powered by mempool.space and v1.5.9 a hotfix for a mailbox message startup issue.

/cc bisq-network/compensation#795

@sqrrm
Copy link
Member

@sqrrm sqrrm commented Mar 3, 2021

Cycle 22 report

I was unwell large part of this cycle. Did minimal review and merge, not requesting anything for the maintainer role.

bisq-network/compensation#788

@ripcurlx
Copy link
Member

@ripcurlx ripcurlx commented Apr 2, 2021

Cycle 23 report

We released v1.6.0, v1.6.1 of and v1.6.2. v1.6.1 was a follow-up release after a v1.6.0 pre-release and v1.6.2 a hotfix release as an issue with SPV resync was introduced in v1.6.0.

/cc bisq-network/compensation#813

@sqrrm
Copy link
Member

@sqrrm sqrrm commented Apr 2, 2021

Cycle 23 report

I haven't done all that much on this role except being moral support for @ripcurlx

bisq-network/compensation#817

@sqrrm
Copy link
Member

@sqrrm sqrrm commented May 7, 2021

Cycle 24 report

Still doing limited maintainer work

bisq-network/compensation#838

@ripcurlx
Copy link
Member

@ripcurlx ripcurlx commented May 10, 2021

Cycle 24 report

We released v1.6.3 and v1.6.4. v1.6.4 was a follow-up release after a v1.6.3 pre-release as we wanted to filter out one infrastructure change and a graceful restart if banned seednode addresses are misconfigured. This was triggered by myself after I published a seednode address to be banned that had an incorrect format. As there is no validation in the filter form, but there is one when the bisq.properties file is read on startup this prevented all nodes that stopped or restarted within a time window of three hours to start. The workaround to start again was to remove the bannedSeednodes line from the bisq.properties file. To prevent this in the future I'll add validation to the filter fields and already removed incorrect configured nodes when read in v1.6.4.

This two releases also include a completely new way to create the installers enabling us to move to a LTS Java version again (11) and also to be able to update JavaFX form now on again.

/cc bisq-network/compensation#846

@sqrrm
Copy link
Member

@sqrrm sqrrm commented Jun 7, 2021

Cycle 25 report

Still doing minimal maintainer work.

bisq-network/compensation#855

@ripcurlx
Copy link
Member

@ripcurlx ripcurlx commented Jun 8, 2021

Cycle 25 report

We released v1.6.5 - no hotfix this time 🥳
The new build pipeline works pretty fine, except for one Java Heap Space Error that is popping up since v1.6.4.

I had to move Travis from https://travis-ci.org to https://travis-ci.com with the downside that even with the free OS plan we have to ask for 25k new free build credits every now and then. Thanks to https://github.com/maxim-belkin we already have a GitHub action in place that verifies nearly everything the current Travis build does. Probably worth to add the last bit as well and get rid of Travis to reduce future maintenance issues.

I also prepared an additional CodeQL GitHub action to run security checks over the code base as well. I also plan to add a security policy to the repository soon.

/cc bisq-network/compensation#860

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants