New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the "Allow edits from maintainers" box in pull requests #4

Open
cbeams opened this Issue Mar 16, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@cbeams
Member

cbeams commented Mar 16, 2018

All pull requests submitted to @bisq-network repositories should enable the "Allow edits from maintainers" option. The checkbox for this option can be found in the right menu of any pull request you create, and if you forget to check the box, you can always come back and do so after pull request creation as well. Here is an example of what a recent pull request in bisq-core with the option enabled:

image

Enabling this option allows Bisq repository maintainers to push additional commits to your pull request, avoiding the need to go back and forth with review comments. This means more productivity for everyone, faster review turnaround times, and more of your changes getting merged.

I believe that once you've checked this box in a given repository, a cookie gets set that always checks the box for future pull requests in that repository, but I'm not certain this is the case. Perhaps GitHub will one day support making this a required option on a repository by repository basis. Until then, please just make sure you check the box.

For more information, see GitHub's documentation on this feature.

cbeams added a commit to bisq-network/bisq-docs that referenced this issue Mar 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment