Skip to content

Conversation

@ayin21
Copy link
Contributor

@ayin21 ayin21 commented Jul 21, 2025

Summary

Donna's buttons to penalize and unpenalize her didn't work when she was stated withe the teamplayer launch script.

Proposed changes

We found a timeout in the button node that was too short for her and that shut off the manual penalize service. We deleted that line so that there is a error message printed if the penalize service isn't found.

Related issues

Checklist

  • [x ] Run colcon build
  • Write documentation
  • Test on your machine
  • [x ] Test on the robot
  • Create issues for future work
  • Triage this PR and label it

@github-project-automation github-project-automation bot moved this to 🆕 New in Software Jul 21, 2025
@ayin21 ayin21 requested a review from Flova July 21, 2025 13:05
@ayin21 ayin21 self-assigned this Jul 21, 2025
@ayin21 ayin21 added the bug Something isn't working label Jul 21, 2025
@github-project-automation github-project-automation bot moved this from 🆕 New to 👀 In review in Software Jul 21, 2025
@Flova Flova merged commit 30a475f into main Jul 21, 2025
2 checks passed
@Flova Flova deleted the fix-donna-button-timeout branch July 21, 2025 13:45
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Software Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants