From af3409e6be4d2e0f97b93b0c8c1a152cfe4d79cf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Viktor=20Sz=C3=A9pe?= Date: Wed, 10 Feb 2021 21:47:51 +0100 Subject: [PATCH 1/2] PHPStan extensions run on max :) ..and phpstan/phpstan-strict-rules --- phpstan.neon | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/phpstan.neon b/phpstan.neon index 120791e..a52bd68 100644 --- a/phpstan.neon +++ b/phpstan.neon @@ -1,5 +1,5 @@ parameters: - level: 7 + level: max inferPrivatePropertyTypeFromConstructor: true fileExtensions: - php From 6a9deec3d8d2f06e22dd1837e0b8cba8d7b8885c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Viktor=20Sz=C3=A9pe?= Date: Wed, 10 Feb 2021 21:53:24 +0100 Subject: [PATCH 2/2] Hope array_pop will surely return an array https://www.php.net/manual/en/function.array-pop.php#refsect1-function.array-pop-returnvalues --- src/bitExpert/PHPStan/Magento/Autoload/FactoryAutoloader.php | 1 + 1 file changed, 1 insertion(+) diff --git a/src/bitExpert/PHPStan/Magento/Autoload/FactoryAutoloader.php b/src/bitExpert/PHPStan/Magento/Autoload/FactoryAutoloader.php index 358b845..f7306f0 100644 --- a/src/bitExpert/PHPStan/Magento/Autoload/FactoryAutoloader.php +++ b/src/bitExpert/PHPStan/Magento/Autoload/FactoryAutoloader.php @@ -55,6 +55,7 @@ public function autoload(string $class): void protected function getFileContents(string $class): string { $namespace = explode('\\', ltrim($class, '\\')); + /** @var string $factoryClassname */ $factoryClassname = array_pop($namespace); $originalClassname = str_replace('Factory', '', $factoryClassname); $namespace = implode('\\', $namespace);