From 4f73bc2d05012eee6a4fed848601d1852f416002 Mon Sep 17 00:00:00 2001 From: Pieter Hoste Date: Sat, 20 Jul 2019 20:31:31 +0200 Subject: [PATCH 1/2] Fix Magic Method call on a DataObject instance --- .../Framework/DataObjectMagicMethodReflectionExtension.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/bitExpert/PHPStan/Magento/Reflection/Framework/DataObjectMagicMethodReflectionExtension.php b/src/bitExpert/PHPStan/Magento/Reflection/Framework/DataObjectMagicMethodReflectionExtension.php index fc0c818..a3bab38 100644 --- a/src/bitExpert/PHPStan/Magento/Reflection/Framework/DataObjectMagicMethodReflectionExtension.php +++ b/src/bitExpert/PHPStan/Magento/Reflection/Framework/DataObjectMagicMethodReflectionExtension.php @@ -13,6 +13,7 @@ namespace bitExpert\PHPStan\Magento\Reflection\Framework; use bitExpert\PHPStan\Magento\Reflection\AbstractMagicMethodReflectionExtension; +use Magento\Framework\DataObject; use PHPStan\Reflection\ClassReflection; class DataObjectMagicMethodReflectionExtension extends AbstractMagicMethodReflectionExtension @@ -24,7 +25,10 @@ class DataObjectMagicMethodReflectionExtension extends AbstractMagicMethodReflec */ public function hasMethod(ClassReflection $classReflection, string $methodName): bool { - return $classReflection->isSubclassOf('Magento\Framework\DataObject') && + $isDataObject = $classReflection->getName() === DataObject::class || + $classReflection->isSubclassOf(DataObject::class); + + return $isDataObject && in_array(substr($methodName, 0, 3), ['get', 'set', 'uns', 'has']); } } From 3e63f79c0b0895d7b9963aebdc682e02f6ad3c12 Mon Sep 17 00:00:00 2001 From: Pieter Hoste Date: Sat, 20 Jul 2019 20:32:14 +0200 Subject: [PATCH 2/2] Ignore the vendor directory --- .gitignore | 1 + 1 file changed, 1 insertion(+) create mode 100644 .gitignore diff --git a/.gitignore b/.gitignore new file mode 100644 index 0000000..57872d0 --- /dev/null +++ b/.gitignore @@ -0,0 +1 @@ +/vendor/