From 77a57dd0636788bc36592579996ad5e24cd0a4d1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stephan=20Hochd=C3=B6rfer?= Date: Sun, 5 Apr 2020 12:23:26 +0200 Subject: [PATCH] Mark (un)set magic methods as having side effects --- .../PHPStan/Magento/Reflection/MagicMethodReflection.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/bitExpert/PHPStan/Magento/Reflection/MagicMethodReflection.php b/src/bitExpert/PHPStan/Magento/Reflection/MagicMethodReflection.php index db5f263..255d2f0 100644 --- a/src/bitExpert/PHPStan/Magento/Reflection/MagicMethodReflection.php +++ b/src/bitExpert/PHPStan/Magento/Reflection/MagicMethodReflection.php @@ -116,6 +116,10 @@ public function getThrowType(): ?\PHPStan\Type\Type public function hasSideEffects(): \PHPStan\TrinaryLogic { + if (in_array(substr($this->name, 0, 3), ['set', 'uns'])) { + return \PHPStan\TrinaryLogic::createYes(); + } + return \PHPStan\TrinaryLogic::createNo(); } }