Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account


merged 3 commits into from Aug 7, 2020


Copy link

@rkalis rkalis commented Aug 5, 2020

This PR adds a new OP_REVERSEBYTES opcode to a new BCH_2020_05_STRICT_SPEC. It also updates the script_tests.json with Bitcoin-ABC's OP_REVERSEBYTES tests. To make the script_tests work without to many changes, I also added a non-strict BCH_2020_05_SPEC, which uses the same standardness checks as BCH_2019_05 (which is not strictly correct for 2020_05, since most of those stanardness checks have been incorporated into the consensus rules.

rkalis and others added 3 commits August 5, 2020 11:05
- Add implementation for OP_REVERSEBYTES
- Add instruction set flag for OP_REVERSEBYTES
- Add new BCH_2020_05_STRICT_SPEC which includes OP_REVERSEBYTES
- Add non-strict version, which uses 2019_05 (plus OP_REVERSEBYTES) rules for unit tests
- Add script_tests for OP_REVERSEBYTES
- Update script tests addendum
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #56 into master will decrease coverage by 0.05%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
- Coverage   98.85%   98.80%   -0.06%     
  Files          88       88              
  Lines        5483     5504      +21     
  Branches      970      971       +1     
+ Hits         5420     5438      +18     
- Misses         27       29       +2     
- Partials       36       37       +1     
Impacted Files Coverage Δ
src/lib/vm/instruction-sets/bch/bch-operations.ts 98.97% <85.71%> (-1.03%) ⬇️
...ib/vm/instruction-sets/bch/bch-instruction-sets.ts 88.75% <93.75%> (-0.65%) ⬇️
...rc/lib/vm/instruction-sets/bch/bch-descriptions.ts 100.00% <100.00%> (ø)
src/lib/vm/instruction-sets/bch/bch-opcodes.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d763523...d0bff0c. Read the comment docs.

@bitjson bitjson merged commit 965bd6f into bitauth:master Aug 7, 2020
4 of 6 checks passed
Copy link

bitjson commented Aug 7, 2020

@rkalis this is fantastic, thanks for the PR! Well done on updating the "addendum" too, I'm sure that was a pain. 😅

Should have a release out shortly 👍

@bitjson bitjson mentioned this pull request Aug 7, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants