dummy feature to show CI #1
Conversation
* main: fail build if IT tests fail
* main: small code cleanup
|
|
Test Plan: ST-3 |
include code coverage / jacoco information * main: code coverage info on PRs add jacoco with unit and integration test analysis Update README.md Update README.md Update README.md Update README.md
There was a problem hiding this comment.
Pull Request Overview
A dummy PR created to showcase continuous integration changes.
- Added a commented-out bug line in the UserRestController.
- Updated the Maven GitHub workflow to add permissions and include a Test Plan link in the build summary and a PR comment.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/java/com/sergiofreire/xray/tutorials/springboot/boundary/UserRestController.java | Introduced a commented-out line labeled as a bug for demonstration purposes. |
| .github/workflows/maven.yml | Updated CI workflow with added permissions and a step to post a Test Plan link. |
| @GetMapping(path="/users" ) | ||
| public List<User> getAllUsers() { | ||
| return userService.getAllUsers(); | ||
| // return null; // bug on purpose |
There was a problem hiding this comment.
[nitpick] Consider removing the commented-out debug code if it is no longer needed, to prevent any potential confusion in the production code.
| // return null; // bug on purpose |
There was a problem hiding this comment.
this is on purpose, for demo on class purpose
|
1 similar comment
|
|
1 similar comment
|
|
1 similar comment
|
|
1 similar comment
|
|
1 similar comment
|
* main: improved code coverage code cleanup avoid dup code bump deps make IndexController render a proper HTML page, LH compliant add environments info fix JDK in Dockerfile Update Twitter link to X in README Correct formatting in README.md Update README.md deploy workflow to render.com fix running using Dockerfile fix building image simple Dockerfile; boots springboot remove unnecessary GH actions temporary PR info add a step to find if we are on a PR run on PR update update workflow to properly run integration tests with jacoco
|
1 similar comment
|
|
1 similar comment
|
|
1 similar comment
|
|
1 similar comment
|
|
|
1 similar comment
|
a dummy PR to showcase CI